Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password improvement #4259

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Password improvement #4259

merged 5 commits into from
Sep 26, 2024

Conversation

sowjanyakch
Copy link
Contributor

#Resolves #4235

password_change_dialog

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the password_improvement branch 3 times, most recently from a3099d8 to d2ef5d4 Compare September 23, 2024 17:50
@sowjanyakch sowjanyakch self-assigned this Sep 23, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Sep 23, 2024
@mahibi
Copy link
Collaborator

mahibi commented Sep 24, 2024

functionality works for me.

Dialog should be material3 design, so rounded corners..
Also for the initial password dialog, only the save button should have primary color.

@sowjanyakch
Copy link
Contributor Author

This is a screenshot of AlertDialog from material3:

material3_dialog

The buttons are basically a text button with text in primary color. I made changes taking it as reference.

Also for the initial password dialog, only the save button should have primary color.

What other color do you want to have for cancel button? I think red looks good.

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi
Copy link
Collaborator

mahibi commented Sep 26, 2024

This is a screenshot of AlertDialog from material3:
material3_dialog

The buttons are basically a text button with text in primary color. I made changes taking it as reference.

Also for the initial password dialog, only the save button should have primary color.

What other color do you want to have for cancel button? I think red looks good.

Current state looks good to me. With the buttons being text only, "cancel" doesn't need to have a different color as suggest by M3 guidelines

@mahibi mahibi merged commit 0354501 into master Sep 26, 2024
13 of 16 checks passed
@mahibi mahibi deleted the password_improvement branch September 26, 2024 11:16
@mahibi
Copy link
Collaborator

mahibi commented Sep 26, 2024

/backport to stable-20.0

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8696
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4259-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve password actions in new conversation screen
2 participants